Grails

Usage of DomainInstance.properties results in a SQL statement that fetches all domains instances

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.0 final
  • Fix Version/s: 2.0.1
  • Component/s: Persistence
  • Labels:
    None
  • Testcase included:
    yes

Description

The attached integration tests demonstrates 2 scenarios where this behavior can be observed. In both tests the properties of 1 domains instance are copied to another.

In test1: 

 p1.properties["firstName", "lastName"] = newPerson.properties

In test2: 

 p1.properties = newPerson.properties.findAll{	it.key == "firstName" || it.key == "lastName"}

In both cases GORM will produce:

 
2012-01-26 09:38:48,178 [main] DEBUG hibernate.SQL  - select this_.id as id0_0_, this_.version as version0_0_, this_.first_name as first3_0_0_, this_.last_name as last4_0_0_, this_.phone_number as phone5_0_0_ from person this_
2012-01-26 09:38:48,180 [main] TRACE sql.BasicExtractor  - found [1] as column [id0_0_]
2012-01-26 09:38:48,181 [main] TRACE sql.BasicExtractor  - found [2] as column [id0_0_]
2012-01-26 09:38:48,181 [main] TRACE sql.BasicExtractor  - found [3] as column [id0_0_]
2012-01-26 09:38:48,207 [main] DEBUG hibernate.SQL  - select count(*) as y0_ from person this_
2012-01-26 09:38:48,208 [main] TRACE sql.BasicExtractor  - found [3] as column [y0_]

If you look at the SQL select, all fields of all records are fetched... I'm not sure why only the IDs are displayed in the logging. I would expect to see first_name, last_name and phone_number as well because they are in the SELECT...

In our application we have hundreds of records which get fetched together with their associations...

A simple workaround is to copy property by property. E.g.: p1.firstName = newPerson.firstName

Activity

Hide
Permalink
Graeme Rocher added a comment -

The issue is the usage of obj.properties = obj2.properties. This for example doesn't produce the problem:

	   p1.properties["firstName", "lastName"] =  [firstName:"Bob", lastName:"Dole"]

We are researching the issue and will have a fix shortly

Show
Graeme Rocher added a comment - The issue is the usage of obj.properties = obj2.properties. This for example doesn't produce the problem: p1.properties[ "firstName" , "lastName" ] = [firstName: "Bob" , lastName: "Dole" ] We are researching the issue and will have a fix shortly

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Svetozar Misljencevic
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: