Service Unit Test with @TestFor using a domain class with an embedded non-domain class results in an exception

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 2.0.1, 2.0.3
Fix Version/s: 2.1.5, 2.2.2, 2.3-M1
Component/s: Testing
Labels:
None

Patch Submitted:

Yes
Patch attached:
Yes

Description

I'm a bit at a loss to isolate the following situation in a isolated testcase. The testcase I tried to create runs without any problems

But the situation causes us problems in migrating our project from Grails 1.3.7 to 2.0.x.
I've got a domain class that contains an embedded Amount object. This Amount class is not a Domain class. Just a simple wrapper around BigDecimal and contained in a model package.

A simplified setup of the domain class:

package domain

import model.Amount

class Record {

    String name
    Amount amount

    static embedded = ['amount']

    static constraints = {
        amount  ()
        name    ()
    }
}

This works fine, however a new test (Using the @TestFor and @Mock annotations) results in the following stacktrace, which suggests that the Amount object is treated as a GORM object?

Invalid property 'id' of bean class [my.package.Amount]: Bean property 'id' is not writable or has an invalid setter method. Does the parameter type of the setter match the return type of the getter?

org.springframework.beans.NotWritablePropertyException: Invalid property 'id' of bean class [my.package.Amount]: Bean property 'id' is not writable or has an invalid setter method. Does the parameter type of the setter match the return type of the getter?
	at org.grails.datastore.mapping.engine.EntityAccess.setProperty(EntityAccess.java:70)
	at org.grails.datastore.mapping.engine.NativeEntryEntityPersister$NativeEntryModifyingEntityAccess.setProperty(NativeEntryEntityPersister.java:1372)
	at org.grails.datastore.mapping.engine.NativeEntryEntityPersister.refreshObjectStateFromNativeEntry(NativeEntryEntityPersister.java:361)
	at org.grails.datastore.mapping.engine.NativeEntryEntityPersister.refreshObjectStateFromNativeEntry(NativeEntryEntityPersister.java:408)
	at org.grails.datastore.mapping.engine.NativeEntryEntityPersister.createObjectFromNativeEntry(NativeEntryEntityPersister.java:338)
	at org.grails.datastore.mapping.engine.NativeEntryEntityPersister.retrieveEntity(NativeEntryEntityPersister.java:305)
	at org.grails.datastore.mapping.engine.EntityPersister.retrieve(EntityPersister.java:158)
	at org.grails.datastore.mapping.core.AbstractSession.retrieve(AbstractSession.java:513)
	at org.grails.datastore.mapping.simple.query.SimpleMapQuery.populateQueryResult(SimpleMapQuery.groovy:720)
	at org.grails.datastore.mapping.simple.query.SimpleMapQuery.executeSubQuery(SimpleMapQuery.groovy:630)
	at org.grails.datastore.mapping.simple.query.SimpleMapQuery.executeQuery(SimpleMapQuery.groovy:63)
	at org.grails.datastore.mapping.query.Query.list(Query.java:486)
	at org.grails.datastore.gorm.finders.AbstractFindByFinder.invokeQuery(AbstractFindByFinder.java:34)
	at org.grails.datastore.gorm.finders.AbstractFindByFinder$1.doInSession(AbstractFindByFinder.java:26)
	at org.grails.datastore.mapping.core.DatastoreUtils.execute(DatastoreUtils.java:301)
	at org.grails.datastore.gorm.finders.AbstractFinder.execute(AbstractFinder.java:40)
	at org.grails.datastore.gorm.finders.AbstractFindByFinder.doInvokeInternal(AbstractFindByFinder.java:24)
	at org.grails.datastore.gorm.finders.DynamicFinder.invoke(DynamicFinder.java:151)
	at org.grails.datastore.gorm.finders.DynamicFinder.invoke(DynamicFinder.java:352)
	at org.grails.datastore.gorm.GormStaticApi$_methodMissing_closure2.doCall(GormStaticApi.groovy:105)
	at org.grails.datastore.gorm.validation.constraints.UniqueConstraint$_processValidate_closure1.doCall(UniqueConstraint.groovy:47)
	at org.grails.datastore.gorm.validation.constraints.UniqueConstraint$_withManualFlushMode_closure2.doCall(UniqueConstraint.groovy:129)
	at org.grails.datastore.gorm.GormStaticApi$_withSession_closure17.doCall(GormStaticApi.groovy:543)
	at org.grails.datastore.mapping.core.DatastoreUtils.execute(DatastoreUtils.java:301)
	at org.grails.datastore.gorm.AbstractDatastoreApi.execute(AbstractDatastoreApi.groovy:34)
	at org.grails.datastore.gorm.GormStaticApi.withSession(GormStaticApi.groovy:542)
	at org.grails.datastore.gorm.validation.constraints.UniqueConstraint.withManualFlushMode(UniqueConstraint.groovy:125)
	at org.grails.datastore.gorm.validation.constraints.UniqueConstraint.processValidate(UniqueConstraint.groovy:39)
	at org.grails.datastore.mapping.validation.ValidatingEventListener.doValidate(ValidatingEventListener.java:83)
	at org.grails.datastore.mapping.validation.ValidatingEventListener.beforeInsert(ValidatingEventListener.java:60)
	at org.grails.datastore.mapping.validation.ValidatingEventListener.onPersistenceEvent(ValidatingEventListener.java:47)
	at org.grails.datastore.mapping.engine.event.AbstractPersistenceEventListener.onApplicationEvent(AbstractPersistenceEventListener.java:46)
	at org.grails.datastore.mapping.engine.EntityPersister.cancelInsert(EntityPersister.java:227)
	at org.grails.datastore.mapping.engine.NativeEntryEntityPersister.executeInsert(NativeEntryEntityPersister.java:1329)
	at org.grails.datastore.mapping.engine.NativeEntryEntityPersister$1.run(NativeEntryEntityPersister.java:698)
	at org.grails.datastore.mapping.core.impl.PendingOperationExecution.executePendingOperation(PendingOperationExecution.java:33)
	at org.grails.datastore.mapping.core.AbstractSession.flushPendingOperations(AbstractSession.java:323)
	at org.grails.datastore.mapping.core.AbstractSession.flushPendingInserts(AbstractSession.java:315)
	at org.grails.datastore.mapping.core.AbstractSession.flush(AbstractSession.java:237)
	at org.grails.datastore.mapping.query.Query.flushBeforeQuery(Query.java:585)
	at org.grails.datastore.mapping.query.Query.list(Query.java:484)
	at org.grails.datastore.gorm.finders.AbstractFindByFinder.invokeQuery(AbstractFindByFinder.java:34)
	at org.grails.datastore.gorm.finders.AbstractFindByFinder$1.doInSession(AbstractFindByFinder.java:26)
	at org.grails.datastore.mapping.core.DatastoreUtils.execute(DatastoreUtils.java:301)
	at org.grails.datastore.gorm.finders.AbstractFinder.execute(AbstractFinder.java:40)
	at org.grails.datastore.gorm.finders.AbstractFindByFinder.doInvokeInternal(AbstractFindByFinder.java:24)
	at org.grails.datastore.gorm.finders.DynamicFinder.invoke(DynamicFinder.java:151)
	at org.grails.datastore.gorm.finders.DynamicFinder.invoke(DynamicFinder.java:352)
	at org.grails.datastore.gorm.GormStaticApi.methodMissing(GormStaticApi.groovy:108)
	at my.package.MyService.doSomething(MyService.groovy:XXX)

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
EmbeddedPropertyBugApp-bug-report-27022013.zip

27/Feb/13 11:30 AM

24 kB

Lari Hotari
grails-app/.../ApplicationResources.groovy 0.1 kB

grails-app/conf/BootStrap.groovy 0.1 kB

grails-app/conf/BuildConfig.groovy 2 kB

grails-app/conf/Config.groovy 4 kB

grails-app/conf/DataSource.groovy 1 kB

grails-app/conf/UrlMappings.groovy 0.2 kB

grails-app/conf/spring/resources.groovy 0.0 kB

grails-app/domain/Person.groovy 0.1 kB

grails-app/i18n/messages.properties 3 kB

grails-app/.../messages_cs_CZ.properties 3 kB

grails-app/i18n/messages_da.properties 3 kB

grails-app/i18n/messages_de.properties 4 kB

grails-app/i18n/messages_es.properties 3 kB

grails-app/i18n/messages_fr.properties 2 kB

grails-app/i18n/messages_it.properties 3 kB

grails-app/i18n/messages_ja.properties 4 kB

grails-app/i18n/messages_nl.properties 3 kB

grails-app/i18n/messages_pl.properties 4 kB

grails-app/.../messages_pt_BR.properties 3 kB

grails-app/.../messages_pt_PT.properties 3 kB

grails-app/i18n/messages_ru.properties 4 kB

grails-app/i18n/messages_sv.properties 3 kB

grails-app/i18n/messages_th.properties 6 kB

grails-app/.../messages_zh_CN.properties 2 kB

grails-app/views/error.gsp 0.3 kB

grails-app/views/index.gsp 3 kB

grails-app/views/layouts/main.gsp 2 kB

src/groovy/Address.groovy 0.1 kB

test/unit/PersonSpec.groovy 0.8 kB

test/unit/PersonTests.groovy 1.0 kB

Showing 30 of 31 items Download Zip
Show

EmbeddedPropertyBugApp-bug-report-27022013.zip

27/Feb/13 11:30 AM

24 kB

Lari Hotari

Activity

Ascending order - Click to sort in descending order

Markus Schwarz made changes - 23/Apr/12 3:01 AM

Field	Original Value	New Value
Status	Open [ 1 ]	Edit [ 10000 ]
Affects Version/s		2.0.3 [ 13094 ]

Burt Beckwith made changes - 15/Jul/12 11:58 PM

Status

Edit [ 10000 ]

Open [ 1 ]

Graeme Rocher made changes - 27/Feb/13 11:22 AM

Fix Version/s		2.1.5 [ 13434 ]
Fix Version/s		2.2.2 [ 13435 ]
Fix Version/s		2.3 [ 13311 ]

Graeme Rocher made changes - 27/Feb/13 11:22 AM

Priority

Major [ 3 ]

Blocker [ 1 ]

Lari Hotari made changes - 27/Feb/13 11:30 AM

Attachment

EmbeddedPropertyBugApp-bug-report-27022013.zip [ 18187 ]

Aaron Long made changes - 03/Mar/13 7:20 PM

Status	Open [ 1 ]	Edit [ 10000 ]
Patch Submitted		Yes [ [10000] ]
Patch attached		Yes [ 10001 ]

Graeme Rocher made changes - 04/Mar/13 12:17 AM

Status

Edit [ 10000 ]

Open [ 1 ]

Graeme Rocher made changes - 04/Mar/13 12:17 AM

Status	Open [ 1 ]	Closed [ 6 ]
Assignee		Graeme Rocher [ graemerocher ]
Resolution		Fixed [ 1 ]

People

Assignee:

Graeme Rocher

Reporter:

Arjan Schaaf

Vote (5)

Watch (5)

Dates

Created:

28/Feb/12 11:00 AM

Updated:

04/Mar/13 12:17 AM

Resolved:

04/Mar/13 12:17 AM

Agile

View on Board