Grails

"action" attribute in g:remoteLink rendered to "action" attribute in HTML

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.1
  • Fix Version/s: 2.2-RC1
  • Component/s: TagLib
  • Labels:

Description

<g:remoteLink action="TOC" update="some_element">blah</g:remoteLink>
renders to
<a href="http://.../TOC" ... action="TOC">blah</a>

In HTML the attribute action within an <a/> Element seems to be invalid, there seems to be no use.

Activity

Ascending order - Click to sort in descending order
Hartmut Bernecker made changes -
Field Original Value New Value
Status Open [ 1 ] Edit [ 10000 ]
Description <g:remoteLink action="TOC" update="some_element">blah</g:remoteLink>
renders to
<a href="http://.../TOC *action="TOC"*>blah</a>

In HTML the attribute action within an <a/> Element seems to be invalid, there seems to be no use. 		<g:remoteLink action="TOC" update="some_element">blah</g:remoteLink>
renders to
<a href="http://.../TOC" ... *action="TOC"*>blah</a>

In HTML the attribute action within an <a/> Element seems to be invalid, there seems to be no use.
Hide
Permalink
MediaInvest Webteam added a comment -

The same problem occurs with the attributes controller and id.
It seems to be an error in the createLink tag witch is called form the remoteLink. The createLink tag do not delete the attributes controller, action and id form the attrs after creating the url.

Show
MediaInvest Webteam added a comment - The same problem occurs with the attributes controller and id. It seems to be an error in the createLink tag witch is called form the remoteLink. The createLink tag do not delete the attributes controller, action and id form the attrs after creating the url.
Repository Branch Revision Date Author/Committer Message
Grails Core master 0b0b205... 2012-05-31 22:22:41 -0700 Bobby Warner / Bobby Warner GRAILS-8900: excluding action and controller from generated action tag
Files Changed
MODIFY grails-plugin-gsp/src/main/groovy/org/codehaus/groovy/grails/plugins/web/taglib/JavascriptTagLib.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x 0b0b205... 2012-05-31 22:22:41 -0700 Bobby Warner / Bobby Warner GRAILS-8900: excluding action and controller from generated action tag
Files Changed
MODIFY grails-plugin-gsp/src/main/groovy/org/codehaus/groovy/grails/plugins/web/taglib/JavascriptTagLib.groovy

Hide
Permalink
Bobby Warner added a comment -

https://github.com/grails/grails-core/pull/210

I created a pull request that excludes "action" and "controller" from generated remote links. ID can't be excluded though because it's a valid attribute for the anchor tag (for CSS). Thanks, Bobby

Show
Bobby Warner added a comment - https://github.com/grails/grails-core/pull/210 I created a pull request that excludes "action" and "controller" from generated remote links. ID can't be excluded though because it's a valid attribute for the anchor tag (for CSS). Thanks, Bobby
Repository Branch Revision Date Author/Committer Message
Grails Core master 669801c... 2012-06-05 07:36:38 -0700 graemerocher / graemerocher Merge pull request #210 from bobbywarner/GRAILS-8900

GRAILS-8900: excluding action and controller from generated action tag
Files Changed

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x 669801c... 2012-06-05 07:36:38 -0700 graemerocher / graemerocher Merge pull request #210 from bobbywarner/GRAILS-8900

GRAILS-8900: excluding action and controller from generated action tag
Files Changed

Bobby Warner made changes -
Assignee Bobby Warner [ bobbywarner ]
Bobby Warner made changes -
Status Edit [ 10000 ] Open [ 1 ]
Hide
Permalink
Bobby Warner added a comment -

Pull request has been merged.

https://github.com/grails/grails-core/commit/0b0b205968a0a9d4a6e55e7fecf83c56be2ff2a0

Show
Bobby Warner added a comment - Pull request has been merged. https://github.com/grails/grails-core/commit/0b0b205968a0a9d4a6e55e7fecf83c56be2ff2a0
Bobby Warner made changes -
Status Open [ 1 ] Closed [ 6 ]
Fix Version/s 2.2 [ 13093 ]
Resolution Fixed [ 1 ]
Repository Branch Revision Date Author/Committer Message
Grails Core master 138520f... 2012-06-05 11:24:27 -0700 Jeff Brown / Jeff Brown Revert "GRAILS-8900: excluding action and controller from generated action tag"

This reverts commit 0b0b205968a0a9d4a6e55e7fecf83c56be2ff2a0.
Files Changed
MODIFY grails-plugin-gsp/src/main/groovy/org/codehaus/groovy/grails/plugins/web/taglib/JavascriptTagLib.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x 138520f... 2012-06-05 11:24:27 -0700 Jeff Brown / Jeff Brown Revert "GRAILS-8900: excluding action and controller from generated action tag"

This reverts commit 0b0b205968a0a9d4a6e55e7fecf83c56be2ff2a0.
Files Changed
MODIFY grails-plugin-gsp/src/main/groovy/org/codehaus/groovy/grails/plugins/web/taglib/JavascriptTagLib.groovy

Hide
Permalink
Jeff Brown added a comment - - edited

Reopening as I reverted the pull request for now. It may be that this change is the right thing to do and it could be put back but someone needs to investigate the failing test and figure out if it is a valid test or not.

Show
Jeff Brown added a comment - - edited Reopening as I reverted the pull request for now. It may be that this change is the right thing to do and it could be put back but someone needs to investigate the failing test and figure out if it is a valid test or not.
Jeff Brown made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Repository Branch Revision Date Author/Committer Message
Grails Core master c8ef614... 2012-06-05 12:43:19 -0700 Bobby Warner / Bobby Warner GRAILS-8900: excluding action and controller from generated action tag and corresponding test-case change
Files Changed
MODIFY grails-plugin-gsp/src/main/groovy/org/codehaus/groovy/grails/plugins/web/taglib/JavascriptTagLib.groovy
MODIFY grails-test-suite-web/src/test/groovy/org/codehaus/groovy/grails/web/taglib/JavascriptTagLibTests.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x c8ef614... 2012-06-05 12:43:19 -0700 Bobby Warner / Bobby Warner GRAILS-8900: excluding action and controller from generated action tag and corresponding test-case change
Files Changed
MODIFY grails-plugin-gsp/src/main/groovy/org/codehaus/groovy/grails/plugins/web/taglib/JavascriptTagLib.groovy
MODIFY grails-test-suite-web/src/test/groovy/org/codehaus/groovy/grails/web/taglib/JavascriptTagLibTests.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core master eeb4124... 2012-06-05 12:46:28 -0700 Jeff Brown / Jeff Brown Merge pull request #218 from bobbywarner/GRAILS-8900-with-test

GRAILS-8900: excluding action and controller from generated action tag and corresponding test-case change
Files Changed

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x eeb4124... 2012-06-05 12:46:28 -0700 Jeff Brown / Jeff Brown Merge pull request #218 from bobbywarner/GRAILS-8900-with-test

GRAILS-8900: excluding action and controller from generated action tag and corresponding test-case change
Files Changed

Hide
Permalink
Bobby Warner added a comment -

The fix has been reapplied with passing test-case now. Thanks, Bobby

https://github.com/grails/grails-core/commit/c8ef6142ea338300af62b2c426ac4a892b164d32

Show
Bobby Warner added a comment - The fix has been reapplied with passing test-case now. Thanks, Bobby https://github.com/grails/grails-core/commit/c8ef6142ea338300af62b2c426ac4a892b164d32
Bobby Warner made changes -
Status Reopened [ 4 ] Closed [ 6 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Bobby Warner
    Reporter:
    Hartmut Bernecker
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: