Grails

g:include broken - when g:applyLayout is used

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Cannot Reproduce
  • Affects Version/s: 2.0.1
  • Fix Version/s: 2.0.4
  • Component/s: View technologies
  • Labels:
  • Environment:
    Windows 7, Grails 2.0.1

Description

g:include is broken - when views being rendered uses g:applyLayout

list-layout.gsp

<!doctype html>
<html>
    <head>
        <meta name="layout" content="main">        
        <title><g:message code="default.list.label" args="[entityName]" /></title>
    </head>
    <body>
        <a href="#list-state" class="skip" tabindex="-1"><g:message code="default.link.skip.label" default="Skip to content&hellip;"/></a>
        <div class="nav" role="navigation">
            <ul>
                <li><a class="home" href="${createLink(uri: '/')}"><g:message code="default.home.label"/></a></li>
                <li><g:link class="create" action="create"><g:message code="default.new.label" args="[entityName]" /></g:link></li>
            </ul>
        </div>
        <div id="list-state" class="content scaffold-list" role="main">
            <h1><g:message code="default.list.label" args="[entityName]" /></h1>
            <g:if test="${flash.message}">
            <div class="message" role="status">${flash.message}</div>
            </g:if>
            <g:layoutBody/>
        </div>
    </body>
</html>

country list.gsp


<%@ page import="org.grails.test.Country" %>
<g:set var="entityName" value="Country" />
<g:applyLayout name="list-layout">
			<table>
				<thead>
					<tr>					
						<g:sortableColumn property="name" title="${message(code: 'country.name.label', default: 'Name')}" />					
					</tr>
				</thead>
				<tbody>
				<g:each in="${countryInstanceList}" status="i" var="countryInstance">
					<tr class="${(i % 2) == 0 ? 'even' : 'odd'}">					
						<td><g:link action="show" id="${countryInstance.id}">${fieldValue(bean: countryInstance, field: "name")}</g:link></td>					
					</tr>
				</g:each>
				</tbody>
			</table>
            <div class="pagination">
                <g:paginate total="${countryInstanceTotal}" />
            </div>           
            <hr> 		
            <!-- Try removing this include as every this will work fine -->	
		    <g:include controller="state" action="list"/>
</g:applyLayout>

state list.gsp

<%@ page import="org.grails.test.State" %>
<g:set var="entityName" value="State" />
<g:applyLayout name="list-layout">
            <table>
                <thead>
                    <tr>                    
                        <g:sortableColumn property="name" title="${message(code: 'state.name.label', default: 'Name')}" />                    
                    </tr>
                </thead>
                <tbody>
                <g:each in="${stateInstanceList}" status="i" var="stateInstance">
                    <tr class="${(i % 2) == 0 ? 'even' : 'odd'}">                    
                        <td><g:link action="show" id="${stateInstance.id}">${fieldValue(bean: stateInstance, field: "name")}</g:link></td>                    
                    </tr>
                </g:each>
                </tbody>
            </table>
            <div class="pagination">
                <g:paginate total="${stateInstanceTotal}" />
            </div>            
</g:applyLayout>

Try accessing /country/list - it would be broken. remove the include and try again - Every thing is fine !
See the attached bug report for working example

The code I pasted above isn't clean - I just wrote it to create a bug report.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-9103 Using url converter interferes on <g:include /> tag, controller/action naming conventions are affected

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Bug - A problem which impairs or prevents the functions of the product. GRAILS-8570 g:set not always setting variable in g:include

  • Critical - Crashes, loss of data, severe memory leak.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
sudhir added a comment -

Inshort - include is broken when called from within <g:applyLayout>

Show
sudhir added a comment - Inshort - include is broken when called from within <g:applyLayout>
Hide
Permalink
Matthias Hryniszak added a comment -

I have tested it with the following example and the mechanism itself seems to work as designed:

grails-app/controller/HomeController.groovy:

class HomeController {
    def index() { [:] }
    def data()  { [ message: "Hello, world! from data" ] }
}

grails-app/views/home/index.gsp:

<html>
    <head>
        <title>Hello, world!</title>
    </head>
    <body>
        <h1><g:include action="data"/></h1>
    </body>
</html>

grails-app/views/home/data.gsp:

<g:applyLayout name="example">
    <head>
        <h3>This is some head</h3>
    </head>
    <body>
        <h3>MESSAGE: ${message}</h3>
    </body>
</g:applyLayout>

grails-app/views/layouts/example.gsp:

<h1>Layout - HEAD</h1>
<g:layoutHead />
<h1>Layout - BODY</h1>
<g:layoutBody />

Tested with Grails 2.0.3 on Windows XP with JDK 1.6.0_30

Show
Matthias Hryniszak added a comment - I have tested it with the following example and the mechanism itself seems to work as designed: grails-app/controller/HomeController.groovy: class HomeController { def index() { [:] } def data() { [ message: "Hello, world! from data" ] } } grails-app/views/home/index.gsp: <html> <head> <title>Hello, world!</title> </head> <body> <h1><g:include action= "data" /></h1> </body> </html> grails-app/views/home/data.gsp: <g:applyLayout name= "example" > <head> <h3>This is some head</h3> </head> <body> <h3>MESSAGE: ${message}</h3> </body> </g:applyLayout> grails-app/views/layouts/example.gsp: <h1>Layout - HEAD</h1> <g:layoutHead /> <h1>Layout - BODY</h1> <g:layoutBody /> Tested with Grails 2.0.3 on Windows XP with JDK 1.6.0_30
Hide
Permalink
sudhir added a comment -

Matthias - may you give a try to the bug report I have attached to jira - it has an example of broken include

Show
sudhir added a comment - Matthias - may you give a try to the bug report I have attached to jira - it has an example of broken include
Hide
Permalink
Matthias Hryniszak added a comment -

Quite frankly there's way to much going on in that example to be a valid test case. You need to simplify it.

Show
Matthias Hryniszak added a comment - Quite frankly there's way to much going on in that example to be a valid test case. You need to simplify it.
Hide
Permalink
Matthias Hryniszak added a comment - - edited

The example throws an exception telling me that there's no applicationContext.xml file. That has nothing to do with Sitemesh.

| Compiling 38 source files

| Running Grails application
| Error 2012-04-08 12:35:00,125 [pool-5-thread-1] ERROR context.ContextLoader  - Context initialization failed
Message: IOException parsing XML document from ServletContext resource [/WEB-INF/applicationContext.xml]; nested exception is java.io.FileNotFoundException: Could not open ServletContext resource [/WEB-INF/applicationContext.xml]
   Line | Method
->> 303 | innerRun in java.util.concurrent.FutureTask$Sync
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|   138 | run      in java.util.concurrent.FutureTask
|   886 | runTask  in java.util.concurrent.ThreadPoolExecutor$Worker
|   908 | run      in     ''
^   662 | run . .  in java.lang.Thread

Caused by FileNotFoundException: Could not open ServletContext resource [/WEB-INF/applicationContext.xml]
->> 303 | innerRun in java.util.concurrent.FutureTask$Sync
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|   138 | run      in java.util.concurrent.FutureTask
|   886 | runTask  in java.util.concurrent.ThreadPoolExecutor$Worker
|   908 | run      in     ''
^   662 | run . .  in java.lang.Thread
| Error 2012-04-08 12:35:00,171 [pool-5-thread-1] ERROR context.GrailsContextLoader  - Error executing bootstraps: IOException parsing XML document from ServletContext resource [/WEB-INF/applicationContext.xml]; nested exception is java.io.FileNotFoundException: Could not open ServletContext resource [/WEB-INF/applicationContext.xml]
Message: IOException parsing XML document from ServletContext resource [/WEB-INF/applicationContext.xml]; nested exception is java.io.FileNotFoundException: Could not open ServletContext resource [/WEB-INF/applicationContext.xml]
   Line | Method
->> 303 | innerRun in java.util.concurrent.FutureTask$Sync
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|   138 | run      in java.util.concurrent.FutureTask
|   886 | runTask  in java.util.concurrent.ThreadPoolExecutor$Worker
|   908 | run      in     ''
^   662 | run . .  in java.lang.Thread

Caused by FileNotFoundException: Could not open ServletContext resource [/WEB-INF/applicationContext.xml]
->> 303 | innerRun in java.util.concurrent.FutureTask$Sync
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|   138 | run      in java.util.concurrent.FutureTask
|   886 | runTask  in java.util.concurrent.ThreadPoolExecutor$Worker
|   908 | run      in     ''
^   662 | run . .  in java.lang.Thread
Show
Matthias Hryniszak added a comment - - edited The example throws an exception telling me that there's no applicationContext.xml file. That has nothing to do with Sitemesh. | Compiling 38 source files | Running Grails application | Error 2012-04-08 12:35:00,125 [pool-5-thread-1] ERROR context.ContextLoader - Context initialization failed Message: IOException parsing XML document from ServletContext resource [/WEB-INF/applicationContext.xml]; nested exception is java.io.FileNotFoundException: Could not open ServletContext resource [/WEB-INF/applicationContext.xml] Line | Method ->> 303 | innerRun in java.util.concurrent.FutureTask$Sync - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - | 138 | run in java.util.concurrent.FutureTask | 886 | runTask in java.util.concurrent.ThreadPoolExecutor$Worker | 908 | run in '' ^ 662 | run . . in java.lang. Thread Caused by FileNotFoundException: Could not open ServletContext resource [/WEB-INF/applicationContext.xml] ->> 303 | innerRun in java.util.concurrent.FutureTask$Sync - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - | 138 | run in java.util.concurrent.FutureTask | 886 | runTask in java.util.concurrent.ThreadPoolExecutor$Worker | 908 | run in '' ^ 662 | run . . in java.lang. Thread | Error 2012-04-08 12:35:00,171 [pool-5-thread-1] ERROR context.GrailsContextLoader - Error executing bootstraps: IOException parsing XML document from ServletContext resource [/WEB-INF/applicationContext.xml]; nested exception is java.io.FileNotFoundException: Could not open ServletContext resource [/WEB-INF/applicationContext.xml] Message: IOException parsing XML document from ServletContext resource [/WEB-INF/applicationContext.xml]; nested exception is java.io.FileNotFoundException: Could not open ServletContext resource [/WEB-INF/applicationContext.xml] Line | Method ->> 303 | innerRun in java.util.concurrent.FutureTask$Sync - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - | 138 | run in java.util.concurrent.FutureTask | 886 | runTask in java.util.concurrent.ThreadPoolExecutor$Worker | 908 | run in '' ^ 662 | run . . in java.lang. Thread Caused by FileNotFoundException: Could not open ServletContext resource [/WEB-INF/applicationContext.xml] ->> 303 | innerRun in java.util.concurrent.FutureTask$Sync - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - | 138 | run in java.util.concurrent.FutureTask | 886 | runTask in java.util.concurrent.ThreadPoolExecutor$Worker | 908 | run in '' ^ 662 | run . . in java.lang. Thread
Hide
Permalink
sudhir added a comment -

When I run that example - It doesn't throw any exception - seems grails bug-report haven't packed it properly.

Show
sudhir added a comment - When I run that example - It doesn't throw any exception - seems grails bug-report haven't packed it properly.
Hide
Permalink
sudhir added a comment -

Matthias I will try to get another clean bug report

Show
sudhir added a comment - Matthias I will try to get another clean bug report
Hide
Permalink
Eugenio Lattanzio added a comment -

Any plans to resolve this? any workaround available since it's blocking for me.

Show
Eugenio Lattanzio added a comment - Any plans to resolve this? any workaround available since it's blocking for me.
Hide
Permalink
Eugenio Lattanzio added a comment -

After debuggin a while, i've noticed i had set grails.web.url.converter = 'hyphenated' after disabling it the g:include start working using camelCase named controller.

So the issue in my case was the g:include used the grails.web.url.converter to name the controllers instead camelCased

maybe this comment can help somebody having the same issue.

Show
Eugenio Lattanzio added a comment - After debuggin a while, i've noticed i had set grails.web.url.converter = 'hyphenated' after disabling it the g:include start working using camelCase named controller. So the issue in my case was the g:include used the grails.web.url.converter to name the controllers instead camelCased maybe this comment can help somebody having the same issue.
Hide
Permalink
Matthias Hryniszak added a comment -

Can you prepare something that's simple and shows the issue? The bug report attached here is way to bloated.

Show
Matthias Hryniszak added a comment - Can you prepare something that's simple and shows the issue? The bug report attached here is way to bloated.
Hide
Permalink
Lari Hotari added a comment -

I've done some fixes related to g:include handling and I couldn't reproduce the problem in latest snapshot. Please re-test with the latest 2.0.x build and re-open this issue if the problem remains.

The test app is missing some files and I had to run "grails upgrade" + disable resources plugin to get it running.

Show
Lari Hotari added a comment - I've done some fixes related to g:include handling and I couldn't reproduce the problem in latest snapshot . Please re-test with the latest 2.0.x build and re-open this issue if the problem remains. The test app is missing some files and I had to run "grails upgrade" + disable resources plugin to get it running.

People

  • Assignee:
    Lari Hotari
    Reporter:
    sudhir
Vote (1)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: