Grails

g:formatNumber should support customizable display of the NaN value

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.1-RC1
  • Component/s: TagLib
  • Labels:
    None
  • Patch attached:
    Yes
  • Testcase included:
    yes

Description

As of now if g:formatNumber is used with NaN value, the default value of DecimalFormatSymbols is returned (\uFFFD). This does not look nice in HTML output.
We should have a way to customize the appearance of NaN values on the webpage. This could be easily done by adding a new attribute:

<g:formatNumber number="${Double.NaN}" nan="n/a"/>

Obviously the Output should be "n/a"

I've already fixed this locally and send a pull request soon.

Activity

Ascending order - Click to sort in descending order
Repository Branch Revision Date Author/Committer Message
Grails Core master c3d75ea... 2012-04-17 14:29:31 -0700 Stefan Armbruster / Stefan Armbruster GRAILS-9036: adding 'nan' attribute to g:formatNumber
Files Changed
MODIFY grails-plugin-gsp/src/main/groovy/org/codehaus/groovy/grails/plugins/web/taglib/FormatTagLib.groovy
MODIFY grails-test-suite-web/src/test/groovy/org/codehaus/groovy/grails/web/taglib/FormatTagLibTests.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core hibernate4 c3d75ea... 2012-04-17 14:29:31 -0700 Stefan Armbruster / Stefan Armbruster GRAILS-9036: adding 'nan' attribute to g:formatNumber
Files Changed
MODIFY grails-plugin-gsp/src/main/groovy/org/codehaus/groovy/grails/plugins/web/taglib/FormatTagLib.groovy
MODIFY grails-test-suite-web/src/test/groovy/org/codehaus/groovy/grails/web/taglib/FormatTagLibTests.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.1.x c3d75ea... 2012-04-17 14:29:31 -0700 Stefan Armbruster / Stefan Armbruster GRAILS-9036: adding 'nan' attribute to g:formatNumber
Files Changed
MODIFY grails-plugin-gsp/src/main/groovy/org/codehaus/groovy/grails/plugins/web/taglib/FormatTagLib.groovy
MODIFY grails-test-suite-web/src/test/groovy/org/codehaus/groovy/grails/web/taglib/FormatTagLibTests.groovy

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x c3d75ea... 2012-04-17 14:29:31 -0700 Stefan Armbruster / Stefan Armbruster GRAILS-9036: adding 'nan' attribute to g:formatNumber
Files Changed
MODIFY grails-plugin-gsp/src/main/groovy/org/codehaus/groovy/grails/plugins/web/taglib/FormatTagLib.groovy
MODIFY grails-test-suite-web/src/test/groovy/org/codehaus/groovy/grails/web/taglib/FormatTagLibTests.groovy

Hide
Permalink
Stefan Armbruster added a comment -

see https://github.com/grails/grails-core/pull/182

Show
Stefan Armbruster added a comment - see https://github.com/grails/grails-core/pull/182
Repository Branch Revision Date Author/Committer Message
Grails Core master 7912c7c... 2012-04-18 00:06:58 -0700 graemerocher / graemerocher Merge pull request #182 from sarmbruster/master

Fix for GRAILS-9036
Files Changed

Repository Branch Revision Date Author/Committer Message
Grails Core hibernate4 7912c7c... 2012-04-18 00:06:58 -0700 graemerocher / graemerocher Merge pull request #182 from sarmbruster/master

Fix for GRAILS-9036
Files Changed

Repository Branch Revision Date Author/Committer Message
Grails Core 2.1.x 7912c7c... 2012-04-18 00:06:58 -0700 graemerocher / graemerocher Merge pull request #182 from sarmbruster/master

Fix for GRAILS-9036
Files Changed

Repository Branch Revision Date Author/Committer Message
Grails Core 2.2.x 7912c7c... 2012-04-18 00:06:58 -0700 graemerocher / graemerocher Merge pull request #182 from sarmbruster/master

Fix for GRAILS-9036
Files Changed

Hide
Permalink
Graeme Rocher added a comment -

Thanks!

Show
Graeme Rocher added a comment - Thanks!
Graeme Rocher made changes -
Field Original Value New Value
Resolution Fixed [ 1 ]
Fix Version/s 2.1 [ 12801 ]
Assignee Graeme Rocher [ graemerocher ]
Status Open [ 1 ] Closed [ 6 ]

People

  • Assignee:
    Graeme Rocher
    Reporter:
    Stefan Armbruster
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: