Grails

Relationship data binding fails for extended classes

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.0.3, 2.0.4
  • Fix Version/s: 2.0.5, 2.1-RC3
  • Component/s: Data binding
  • Labels:
    None
  • Environment:
    Ubuntu
  • Testcase included:
    yes

Description

The binding of foreign key domains fails when the foreign key is defined in the parent class after upgrading from version 2.0.1

For example, with the base class person:

Person.groovy
class Person {

    Name name
    String occupation

    static constraints = {
    }

    static mapping = {
        name cascade: "all"
    }

}

and the implementing class PersonExtended:

PersonExtended.groovy
class PersonExtended extends Person {

    static constraints = {
    }
}

and the foreign key Name:

Name.groovy
class Name {

    String title
    String firstName
    String surname

    static constraints = {
    }
}

I am unable to set the name fields on PersonExtended with the same params that works ok for Person.

def personInstance = new Person(params)
def personExtendedInstance = new PersonExtended(params)

assert personInstance.name // Passes
assert personExtendedInstance.name // Fails

I have attached a sample 2.0.4 project with a single unit test to illustrate the issue.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-8998 Custom structured property editor data binding support broken after upgrade from 2.0.1 to 2.0.2 / 2.0.3

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-9165 Cannot bind Date to subclass domain posting from enctype=multipart/form-date

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Leo Jin added a comment -

Same issue experienced please fix

Show
Leo Jin added a comment - Same issue experienced please fix
Hide
Permalink
Jeff Brown added a comment - - edited

Bill,

I think I have fixed the binding problem. However, your test is still failing. The assertions in the controller are passing because the binding works now but there is an assertion in the test that is still failing.

test/unit/bindingissue/PersonControllerTests.groovy
package bindingissue

import grails.test.mixin.*

@TestFor(PersonController)
@Mock([Person, PersonExtended, Name])
class PersonControllerTests {


    def populateValidParams(params) {
        assert params != null
        params['occupation'] = "Computer Programmer"
        params['name.title'] = "Mr"
        params['name.firstName'] = "John"
        params['name.surname'] = "Smith"
    }


    void testSave() {

        populateValidParams(params)
        controller.save()

        assert response.json.person
        assert response.json.person.occupation
        assert response.json.person.name
        // For some reason the name fields are not being output via json so this fails
        assert response.json.person.name.title

        assert response.json.personExtended
        assert response.json.personExtended.occupation
        assert response.json.personExtended.name
        assert response.json.personExtended.name.title

    }


}

The response.json.person.name.title assertion is failing. That seems like a separate issue. It looks like the assertions that you have in the controller cover the data binding concerns. Is that correct?

Show
Jeff Brown added a comment - - edited Bill, I think I have fixed the binding problem. However, your test is still failing. The assertions in the controller are passing because the binding works now but there is an assertion in the test that is still failing. test/unit/bindingissue/PersonControllerTests.groovy package bindingissue import grails.test.mixin.* @TestFor(PersonController) @Mock([Person, PersonExtended, Name]) class PersonControllerTests { def populateValidParams(params) { assert params != null params['occupation'] = "Computer Programmer" params['name.title'] = "Mr" params['name.firstName'] = "John" params['name.surname'] = "Smith" } void testSave() { populateValidParams(params) controller.save() assert response.json.person assert response.json.person.occupation assert response.json.person.name // For some reason the name fields are not being output via json so this fails assert response.json.person.name.title assert response.json.personExtended assert response.json.personExtended.occupation assert response.json.personExtended.name assert response.json.personExtended.name.title } } The response.json.person.name.title assertion is failing. That seems like a separate issue. It looks like the assertions that you have in the controller cover the data binding concerns. Is that correct?
Hide
Permalink
Bill Thornton added a comment -

Hi Jeff,

Many thanks for looking at the issue.

Yes, the assertions in the controller are the ones that cover this specific issue. I am unsure why the "response.json.person.name.title" assert fails, but it is not to do with the raised issue.

Cheers,
Bill

Show
Bill Thornton added a comment - Hi Jeff, Many thanks for looking at the issue. Yes, the assertions in the controller are the ones that cover this specific issue. I am unsure why the "response.json.person.name.title" assert fails, but it is not to do with the raised issue. Cheers, Bill
Hide
Permalink
Jeff Brown added a comment -

Bill,

Great.

If you would, please raise a separate JIRA for the JSON issue. So as not to complicate the issue it is probably best to leave the data binding concern out of that one. I think the 2 are almost certainly unrelated issues. In a sample app for that one you could eliminate the data binding issue by just creating the object graph yourself without using data binding and then rendering that object as JSON.

Thanks again for the help.

Show
Jeff Brown added a comment - Bill, Great. If you would, please raise a separate JIRA for the JSON issue. So as not to complicate the issue it is probably best to leave the data binding concern out of that one. I think the 2 are almost certainly unrelated issues. In a sample app for that one you could eliminate the data binding issue by just creating the object graph yourself without using data binding and then rendering that object as JSON. Thanks again for the help.
Hide
Permalink
Jeff Brown added a comment -

This isn't really the same problem as GRAILS-8998 but the 2 were fixed at the same time. When testing the fix for GRAILS-8998 I realized the inheritance problem as it relates to structured editors and fixed it. That fix covers the issue described here as well.

Sorry for the trouble.

Show
Jeff Brown added a comment - This isn't really the same problem as GRAILS-8998 but the 2 were fixed at the same time. When testing the fix for GRAILS-8998 I realized the inheritance problem as it relates to structured editors and fixed it. That fix covers the issue described here as well. Sorry for the trouble.

People

  • Assignee:
    Jeff Brown
    Reporter:
    Bill Thornton
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: