Grails

Performance problem in GroovyPageParser in development mode

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.1.2, 2.2-RC2
  • Component/s: None
  • Labels:
    None

Description

This line is a performance bottleneck in GroovyPageParser:
https://github.com/grails/grails-core/blob/master/grails-web/src/main/groovy/org/codehaus/groovy/grails/web/pages/GroovyPageParser.java#L187

PluginBuildSettings pluginBuildSettings = new PluginBuildSettings(BuildSettingsHolder.getSettings());

It's only a problem in development mode.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. GRAILS-6183 GSPs are recompiled on server restarts, though unchanged and class file exist.

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brandon Fish added a comment -

Could this also be applied to 2.0.x ?

Show
Brandon Fish added a comment - Could this also be applied to 2.0.x ?
Hide
Permalink
Lari Hotari added a comment -

Brandon, there isn't any technical reasons against that but currently 2.0.x is in maintenance mode and only critical fixes are applied in that branch. Is there any reason that you cannot use 2.1.x ? This fix will be included in 2.1.2 which hasn't been released yet. You can try the fix by getting the 2.1.2.BUILD-SNAPSHOT version.

Show
Lari Hotari added a comment - Brandon, there isn't any technical reasons against that but currently 2.0.x is in maintenance mode and only critical fixes are applied in that branch. Is there any reason that you cannot use 2.1.x ? This fix will be included in 2.1.2 which hasn't been released yet. You can try the fix by getting the 2.1.2.BUILD-SNAPSHOT version .
Hide
Permalink
Brandon Fish added a comment -

I will be moving to 2.1 eventually but still using 2.0.x for the near future.

I understand this is not critical but I thought you might consider applying it to 2.0.x if it has minimal chances for regression and is a significant performance boost for everyone currently using 2.0.x.

Thanks.

Show
Brandon Fish added a comment - I will be moving to 2.1 eventually but still using 2.0.x for the near future. I understand this is not critical but I thought you might consider applying it to 2.0.x if it has minimal chances for regression and is a significant performance boost for everyone currently using 2.0.x. Thanks.

People

  • Assignee:
    Lari Hotari
    Reporter:
    Lari Hotari
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: