Grails Maven Plugin

Grails Maven Groovy Eclipse Compatibilibity Enhancements - Please Vote

Details

  • Type: Sub-task Sub-task
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

It would be a somewhat easier to use if Grails, Maven, Eclipse and the EclipseGroovyPlugin and Ant were all configured with mutually compatible directory structures etc etc.

If you feel the same way at least please vote so Graeme Rocher can see it.

Yes, acknowledge that Graeme hates Maven (don't we all at times ?) Not asking for that to be changed.

My wish is not that it go Maven, because others are already addressing that to the degree possible. But if the various pieces would just (for example) use compatible directory structures (as in maven's) then goll durn my life would be easier because then I could structure all my projects using the same stupid directory structure and not have my tools seeming to fight each other.

No disrespect intended to Graeme Rocher or any other contributor, but there's a ton of us out there that are all tied to Maven/Eclipse, love/hate and all. Doesn't mean we married the right technology, but the various technologies could all work together fine (Ant and Maven for example) if they weren't pitted against each other by somewhat mutually exclusive setup requirements. Even groovy and the groovy eclipse plugin seem to fight each other a little bit.

Also not saying it can't be made to work as it is, just that it's un-necessarily awkward at times. Please at least vote.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
johan Eltes added a comment -

I'm an addictive user of the eclipse:eclipse maven plug-in. If it could be updated to generate the groovy facet it would be really great. As it stands, I have to assign src/main/groovy as a source directory manually in my project settings in Eclipse. After the next ... mvn eclipse:clean eclipse:eclipse ... it is gone... Something equivalent for Grails would be great, whether it is an extention to eclipse:eclipse or grails-specific plug-in.

Show
johan Eltes added a comment - I'm an addictive user of the eclipse:eclipse maven plug-in. If it could be updated to generate the groovy facet it would be really great. As it stands, I have to assign src/main/groovy as a source directory manually in my project settings in Eclipse. After the next ... mvn eclipse:clean eclipse:eclipse ... it is gone... Something equivalent for Grails would be great, whether it is an extention to eclipse:eclipse or grails-specific plug-in.
Hide
Permalink
Luis Arias added a comment -

eclipse:eclipse is definitely a needed feature. In Octo's earlier maven plugin, Arnaud had written the following mojo to do this:

http://forge.octo.com/svn/mtg/grails-maven-plugin/trunk/src/main/java/com/octo/mtg/plugin/MvnConfigDirectoriesMojo.java

Maybe that could be reused in the current plugin ?

Show
Luis Arias added a comment - eclipse:eclipse is definitely a needed feature. In Octo's earlier maven plugin, Arnaud had written the following mojo to do this: http://forge.octo.com/svn/mtg/grails-maven-plugin/trunk/src/main/java/com/octo/mtg/plugin/MvnConfigDirectoriesMojo.java Maybe that could be reused in the current plugin ?
Hide
Permalink
Luis Arias added a comment -

Oh I see now from the source code that this mojo was used but that there is a bunch of stuff commented out here. What are the issues ?

Show
Luis Arias added a comment - Oh I see now from the source code that this mojo was used but that there is a bunch of stuff commented out here. What are the issues ?
Hide
Permalink
Luis Arias added a comment -

I restored the commented out lines in this patch which gives a much better eclipse:eclipse experience than the current version. I need to use the JSecurity plugin so I'll see if I can do the plugin stuff here too.

Show
Luis Arias added a comment - I restored the commented out lines in this patch which gives a much better eclipse:eclipse experience than the current version. I need to use the JSecurity plugin so I'll see if I can do the plugin stuff here too.
Hide
Permalink
Luis Arias added a comment -

Slightly better patch uses projectDir throughout.

Show
Luis Arias added a comment - Slightly better patch uses projectDir throughout.
Hide
Permalink
Peter Ledbrook added a comment -

Sorry Luis, I hadn't noticed your comments till now. Thanks for the patch - I'll try it out next week.

Show
Peter Ledbrook added a comment - Sorry Luis, I hadn't noticed your comments till now. Thanks for the patch - I'll try it out next week.
Hide
Permalink
Luis Arias added a comment -

No problem Peter. I did some work on getting plugin source and jar dependencies into the picture, but I finally reached the conclusion that it would be better to have more direct control of writing the eclipse project files by writing a maven-eclipse-plugin goal instead. I have a very initial version that simply puts the groovy nature in the project by using the appropriate extension point here on launchpad:

https://code.launchpad.net/~kaaloo/grails/maven-eclipse-plugin

I haven't had time to get back to it, but now that I finally was able to resolve some issues with jsecurity (JSEC-56 and JSEC-58) that were impeding progression on my current work with grails, I would like to get back to that. Let me know what you think. My next step would be to refactor the source directory generation code in the grails-maven-plugin to this grails goal so the approach can be validated. Then see how to work with some of the api in the grails-maven-plugin to get back to the plugin issue again.

Show
Luis Arias added a comment - No problem Peter. I did some work on getting plugin source and jar dependencies into the picture, but I finally reached the conclusion that it would be better to have more direct control of writing the eclipse project files by writing a maven-eclipse-plugin goal instead. I have a very initial version that simply puts the groovy nature in the project by using the appropriate extension point here on launchpad: https://code.launchpad.net/~kaaloo/grails/maven-eclipse-plugin I haven't had time to get back to it, but now that I finally was able to resolve some issues with jsecurity (JSEC-56 and JSEC-58) that were impeding progression on my current work with grails, I would like to get back to that. Let me know what you think. My next step would be to refactor the source directory generation code in the grails-maven-plugin to this grails goal so the approach can be validated. Then see how to work with some of the api in the grails-maven-plugin to get back to the plugin issue again.
Hide
Permalink
Luis Arias added a comment -

Actually I also have a bazaar branch of the grails-maven-plugin with my patches here:

https://code.launchpad.net/~kaaloo/grails/grails-maven-plugin

It might be easier for you simply to branch and build from there.

Show
Luis Arias added a comment - Actually I also have a bazaar branch of the grails-maven-plugin with my patches here: https://code.launchpad.net/~kaaloo/grails/grails-maven-plugin It might be easier for you simply to branch and build from there.
Hide
Permalink
Peter Ledbrook added a comment -

I've deployed a new 1.0-SNAPSHOT version of the plugin with your patch applied. Please let me know whether it works as required.

Show
Peter Ledbrook added a comment - I've deployed a new 1.0-SNAPSHOT version of the plugin with your patch applied. Please let me know whether it works as required.
Hide
Permalink
Luis Arias added a comment -

That's working great, thanks Peter !

Show
Luis Arias added a comment - That's working great, thanks Peter !
Hide
Permalink
Peter Ledbrook added a comment -

I've had to change it because the patch broke "out-of-workspace" projects. The ".launch" file now uses:

${project_loc:<proj.name>}

where <proj.name> is the hard-coded name of the project. That should still solve the problem you were having.

Show
Peter Ledbrook added a comment - I've had to change it because the patch broke "out-of-workspace" projects. The ".launch" file now uses: 
${project_loc:<proj.name>}
where <proj.name> is the hard-coded name of the project. That should still solve the problem you were having.
Hide
Permalink
Peter Ledbrook added a comment -

Ooops...think I'm confused. This is not the issue I thought it was. Ignore me!

Show
Peter Ledbrook added a comment - Ooops...think I'm confused. This is not the issue I thought it was. Ignore me!
Hide
Permalink
Peter Ledbrook added a comment -

Luis' patch has made it in. We'll look at "grails-maven-plugin" later. As for the original issue, it's a bit too open ended. I might convert it to a top-level task with sub-tasks.

Show
Peter Ledbrook added a comment - Luis' patch has made it in. We'll look at "grails-maven-plugin" later. As for the original issue, it's a bit too open ended. I might convert it to a top-level task with sub-tasks.
Hide
Permalink
Graeme Rocher added a comment -

There is no scope / time to resolve these remaining lower priority issues for 1.2 so moving to 1.3

for 1.2 final only issues considered blocking will now be fixed

Show
Graeme Rocher added a comment - There is no scope / time to resolve these remaining lower priority issues for 1.2 so moving to 1.3 for 1.2 final only issues considered blocking will now be fixed

People

Vote (33)
Watch (14)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.1#660-r161644) | Report a problem
Powered by a free Atlassian JIRA open source license for Grails project. Try JIRA - bug tracking software for your team.