Uploaded image for project: 'Grails'
  1. Grails
  2. GRAILS-8900

"action" attribute in g:remoteLink rendered to "action" attribute in HTML

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.2-RC1
    • Component/s: TagLib
    • Labels:

      Description

      <g:remoteLink action="TOC" update="some_element">blah</g:remoteLink>
      renders to
      <a href="http://.../TOC" ... action="TOC">blah</a>

      In HTML the attribute action within an <a/> Element seems to be invalid, there seems to be no use.

        Activity

        Hartmut Bernecker created issue -
        Hartmut Bernecker made changes -
        Field Original Value New Value
        Status Open [ 1 ] Edit [ 10000 ]
        Description <g:remoteLink action="TOC" update="some_element">blah</g:remoteLink>
        renders to
        <a href="http://.../TOC *action="TOC"*>blah</a>

        In HTML the attribute action within an <a/> Element seems to be invalid, there seems to be no use.
        <g:remoteLink action="TOC" update="some_element">blah</g:remoteLink>
        renders to
        <a href="http://.../TOC" ... *action="TOC"*>blah</a>

        In HTML the attribute action within an <a/> Element seems to be invalid, there seems to be no use.
        Hide
        MediaInvest Webteam added a comment -

        The same problem occurs with the attributes controller and id.
        It seems to be an error in the createLink tag witch is called form the remoteLink. The createLink tag do not delete the attributes controller, action and id form the attrs after creating the url.

        Show
        MediaInvest Webteam added a comment - The same problem occurs with the attributes controller and id. It seems to be an error in the createLink tag witch is called form the remoteLink. The createLink tag do not delete the attributes controller, action and id form the attrs after creating the url.
        Hide
        Bobby Warner added a comment -

        https://github.com/grails/grails-core/pull/210

        I created a pull request that excludes "action" and "controller" from generated remote links. ID can't be excluded though because it's a valid attribute for the anchor tag (for CSS). Thanks, Bobby

        Show
        Bobby Warner added a comment - https://github.com/grails/grails-core/pull/210 I created a pull request that excludes "action" and "controller" from generated remote links. ID can't be excluded though because it's a valid attribute for the anchor tag (for CSS). Thanks, Bobby
        Bobby Warner made changes -
        Assignee Bobby Warner [ bobbywarner ]
        Bobby Warner made changes -
        Status Edit [ 10000 ] Open [ 1 ]
        Show
        Bobby Warner added a comment - Pull request has been merged. https://github.com/grails/grails-core/commit/0b0b205968a0a9d4a6e55e7fecf83c56be2ff2a0
        Bobby Warner made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 2.2 [ 13093 ]
        Resolution Fixed [ 1 ]
        Hide
        Jeff Scott Brown added a comment - - edited

        Reopening as I reverted the pull request for now. It may be that this change is the right thing to do and it could be put back but someone needs to investigate the failing test and figure out if it is a valid test or not.

        Show
        Jeff Scott Brown added a comment - - edited Reopening as I reverted the pull request for now. It may be that this change is the right thing to do and it could be put back but someone needs to investigate the failing test and figure out if it is a valid test or not.
        Jeff Scott Brown made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Hide
        Bobby Warner added a comment -

        The fix has been reapplied with passing test-case now. Thanks, Bobby

        https://github.com/grails/grails-core/commit/c8ef6142ea338300af62b2c426ac4a892b164d32

        Show
        Bobby Warner added a comment - The fix has been reapplied with passing test-case now. Thanks, Bobby https://github.com/grails/grails-core/commit/c8ef6142ea338300af62b2c426ac4a892b164d32
        Bobby Warner made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Bobby Warner
            Reporter:
            Hartmut Bernecker
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: